Group as dev dependency

[millnut]

I think drupal/group now needs adding as a dev dependency so tests can run see failures here https://github.com/localgovdrupal/localgov_project/actions/runs/6316343354/job/17318874731

I believe that is how drupal/scheduled_transitions is handled in https://github.com/localgovdrupal/localgov_alert_banner/blob/1.x/composer.json for the same reasons

@finnlewis, @Adnan-cds, @andybroomfield on thoughts on this?

[andybroomfield]

Sounds like a good idea.
Same for localgovdrupal/localgov_core for the full screen alert banner (although that one does not have tests yet!)

[andybroomfield]

Question is, which version of Group?

[millnut]

@andybroomfield this is where it will get complex as microsites uses 3, @Adnan-cds what version of Group is the submodule compatible with?

If it's not targeting a specific version we can probably do;

"drupal/group": "^2 || ^3",

[millnut]

Hmm it also requires localgov_microsites_group which could get complex quickly. Adding @stephen-cox here for his thoughts?

It is starting to feel that this submodule should exist as its own module or a submodule within localgov_microsites_group that is dependent on localgov_microsites_group and localgov_alert_banner not as a submodule within localgov_alert_banner

[andybroomfield]

@millnut I don't see localgov_microsites_group as a test dependency here , and thats the only test.

I think the sub module can be used as a generic group plugin, there are just some extra (optional?) config that gets installed on microsites. If group 3 is the what microsites uses it makes sense thats what we target.

[millnut]

@andybroomfield sorry that was my bad, it was flagging as it couldn't work out the class due to microsites_group missing when the localgov_alert_banner is checked in PHPStan as part of the main project; I'll add some ignores around that

[Adnan-cds]

This snippet from the Github test runner should have taken care of this issue. Not sure why it didn't. Anyway, having drupal/groups:^3 as a dev dependency is not a bad idea.

I can confirm that there is no dependency on localgov_microsites_group.

[millnut]

Hi @Adnan-cds the localgov_microsites_group dependency I’m seeing here for the helper https://github.com/localgovdrupal/localgov_alert_banner/blob/1.x/modules/group_alert_banner/group_alert_banner.module#L55. cc: @andybroomfield

[Adnan-cds]

That's right. The relevant function is a hook implementation. It is triggered only if the localgov_microsites_group module is available and ignored otherwise.

[millnut]

Great thanks for clarifying @Adnan-cds I now have a better understanding of how that works now.

[Adnan-cds]

No problem.