Make banner block type display configurable.

[j4-m]

• Adds a block form which allows admins to choose the alter banner types they want the block to display
• Use the configuration to filter the queried alter banners before render.

[andybroomfield]

Thanks @Iam-Jam
Do you know why the tests are failing, saying missing schemas?

[j4-m]

Moving to WIP as we'll need to update the tests to cover the new configuration.

[andybroomfield]

Thanks for your work so far @Iam-Jam.
I'm seeing an error on the block configuration screen on first install.

Error message
Warning: Invalid argument supplied for foreach() in Drupal\Core\Render\Element\Checkboxes::valueCallback() (line 100 of core/lib/Drupal/Core/Render/Element/Checkboxes.php).

[j4-m]

No worries @andybroomfield. As of the latest commits, there shouldn't be any errors when saving the configuration form and hopefully the schema issue has been resolve too... just need add some test coverage now.

[andybroomfield]

Thanks for your efforts on this @Iam-Jam.

I'm still seeing the following error on the block configuration page when first installing the module.

Error message
Warning: Invalid argument supplied for foreach() in Drupal\Core\Render\Element\Checkboxes::valueCallback() (line 100 of core/lib/Drupal/Core/Render/Element/Checkboxes.php).

To replicate, do a fresh install and enable localgov_alert_banner. Then go to the block configuration screen without having placed a block.
The error will disapear once I save the block for the first time.

Additonal amends:

• Can we change the label Display types to Banner types to match the admin view.
• Would it be possible to have the negate this condition option added

[finnlewis]

I can confirm the same error.
I can't immediately see why the default_value key is just "" when it is expecting an array.
If you can show me how to fix this, I can use it as a debugging demo at OxDUG!

[andybroomfield]

@finnlewis @Iam-Jam I think this might be what is causing the error.
I think default value should be an array (even if it is null).

[j4-m]

Yep that's it @andybroomfield. I had actually spotted this before but forgot to fix it. Shame this hasn't been picked up in tests.

[andybroomfield]

Just to confirm that changing
'#default_value' => !empty($config['include_types']) ? $config['include_types'] : '',
to
'#default_value' => !empty($config['include_types']) ? $config['include_types'] : [],
resolves this issue. If we can get this change added we can get this in a new release.

[finnlewis]

Ditto. @j4-m could you commit the change to your forked branch?

[finnlewis]

Yes - I got the same place following the debugger and the code changes :)

[andybroomfield]

Hi @j4-m Thanks for your efforts so far. I'm stlll getting the error, did we get anywhere with this?

[j4-m]

@andybroomfield @finnlewis the amendment to the default value has just gone in.

[andybroomfield]

Error now fixed so clear to merge @j4-m