"Remove hide link" checkbox for full page banner #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiding the "Remove hide link" checkbox from the edit form of Full page alert banners. The "Remove hide link" checkbox is irrelevant for Full page alert banners as we don't want to remove the "Hide" link from full page banners. This is because a full page banner without a hide link prevents people from reaching the actual site content!
Programmatic update to hide the "Remove hide link" checkbox from the Full page alert's edit form. This update is relevant for existing users of the Full page banner only.
|
Leaving it in Draft state for now. Waiting for test runs to be back to normal. |
Adnan-cds
changed the title
|
Tests are passing, so ready for review :) |
andybroomfield
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
This makes sense and I've been able to verify the hide link is removed following db update.
I noticed that pre update, it wasn't possible to display the banner anyway if the hide link was checked, was that intentional. Either way better it is removed for the full page version.
Hi Andy, thanks for the approval. But no, this was not intentional. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #189
Updated config file and accompanying programmatic update to hide the "Remove hide link" checkbox from the Full page alert banner's edit form.
The "Remove hide link" checkbox is irrelevant for Full page alert banners as we don't want to remove the "Hide" link from full page banners. This is because a full page banner without a hide link prevents people from reaching the actual site content!