Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github actions configuration to try to test against PHP 7.4 an… #192

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

finnlewis
Copy link
Member

…d 8.1 and only run coding standards and phpstan checks against code in this repository.

@finnlewis
Copy link
Member Author

Hey people - how's this looking?

I think I've configured the tests to try both PHP 7.4 and 8.1 and to only run coding standards, phpstan and phpunit tests on code from this repository.

It looks like the tests are passing too!

If this looks like a good pattern we can copy this for Drupal modules and set up a fuller integration test for the profile.

Any comments or suggestions welcome!

Copy link
Contributor

@Adnan-cds Adnan-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good actually :)

Copy link
Contributor

@andybroomfield andybroomfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and they run ok.
Little concerned there is a skipped test... Do we know what it is?

@finnlewis
Copy link
Member Author

Not sure that the skipped test is @andybroomfield .

Here's the output of my local test run, which does have some deprecation notices, but does not appear to skip any of the 16 tests:

#193

@andybroomfield
Copy link
Contributor

@finnlewis it is on the checks results page

Run mkdir -p ./html/web/sites/simpletest && chmod 777 ./html/web/sites/simpletest
Running phpunit in 4 processes with /var/www/html/vendor/phpunit/phpunit/phpunit

Configuration read from /var/www/html/phpunit.xml.dist

...............S                                                  16 / 16 (100%)

Time: 01:31.301, Memory: 10.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 16, Assertions: 23[9](https://github.com/localgovdrupal/localgov_alert_banner/runs/5872911846?check_suite_focus=true#step:5:9), Skipped: 1.

@finnlewis
Copy link
Member Author

Hey @andybroomfield , yes I see the output from the Github checks, but I don't know what the skipped test is as it does not do the same locally. The 16th test appears to be :

Scheduling (Drupal\Tests\localgov_alert_banner\Kernel\Scheduling)
✔ Alert banner scheduling

Any idea why that would skip in some circumstances?

I guess it is this one:

https://github.com/localgovdrupal/localgov_alert_banner/blob/release-1.x/tests/src/Kernel/SchedulingTest.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants