-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Github actions configuration to try to test against PHP 7.4 an… #192
Conversation
…d 8.1 and only run coding standards and phpstan checks against code in this repository.
Hey people - how's this looking? I think I've configured the tests to try both PHP 7.4 and 8.1 and to only run coding standards, phpstan and phpunit tests on code from this repository. It looks like the tests are passing too! If this looks like a good pattern we can copy this for Drupal modules and set up a fuller integration test for the profile. Any comments or suggestions welcome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good actually :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and they run ok.
Little concerned there is a skipped test... Do we know what it is?
Not sure that the skipped test is @andybroomfield . Here's the output of my local test run, which does have some deprecation notices, but does not appear to skip any of the 16 tests: |
@finnlewis it is on the checks results page
|
Hey @andybroomfield , yes I see the output from the Github checks, but I don't know what the skipped test is as it does not do the same locally. The 16th test appears to be : Scheduling (Drupal\Tests\localgov_alert_banner\Kernel\Scheduling) Any idea why that would skip in some circumstances? I guess it is this one: |
…d 8.1 and only run coding standards and phpstan checks against code in this repository.