-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for new entity permissions form #219
Conversation
Discussed at Merge Monday. Thinking was we can add a dependency to Drupal 9.4 and release it as 1.5.x |
Discussed in Merge Monday, @andybroomfield will reawaken this now that 9.4 is out and 9.3 is deprecated. |
Still on Andy's backlog, probably not get to this for another month at least. |
638a29c
to
ec3e516
Compare
Updated this PR dropping support for Drupal 8 and everything below Drupal 9.4 (core 9.4+ or 10). Once #244 and #246 are merged, they will make up the final release of the 1.5.x series. |
Ref #218 Add new annotation to get the alert banner permissions form on the manage alert banner type entity. Also changes the alert banner permissions generator to make sure are assigned to the alert banner entity using BundlePermissionHandlerTrait
As banner types now use path /admin/structure/alert-banner-types
Drops support for Drupal 8 and Drupal less than 9.4 which does not have the BundlePermissionHandlerTrait.
ec3e516
to
fb0ab46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds the permissions form, but I'm not sure if it's working as expected. If it is working it's a little confusing.
If I remove the 'View alert banner entities of type Alert banner' permission on the new permissions tab it has no effect because it's overridden by the global permission with the same name. I would expect the permission on a banner type to override the global permission when removing permissions.
I think it is working. But it is confusing indeed :D |
Code looks good to me. But we really need to be sure if this is working or not. |
Yes, thats expected behaviour (global permission overrides per entity type), as the view all are assigned to anon user and auth user, and manage to emergrency publisher. We might consider actully removing the global permissions, that would require update hook to re-assign them. My only counter to this is that some teams may have set up a different role and granted a global permission. |
Could do with testing to confirm that the sub-set of permissions page works as expected. I'm happy to test further! :) |
Would like to pick this up again.
We could then look at supporting the new permissions tab on other custom entities such as geo. |
@stephen-cox also happy with this approach... so I'll let you confirm before / if testing further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine. Happy to merge this and rationalise the permissions in another ticket.
Ref #218
Add new annotation to get the alert banner permissions form on the manage alert banner type
entity.
Also changes the alert banner permissions generator to make sure are assigned to the alert
banner entity using BundlePermissionHandlerTrait