Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cookie handling #221

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Fix: Cookie handling #221

merged 1 commit into from
Sep 8, 2022

Conversation

Adnan-cds
Copy link
Contributor

@Adnan-cds Adnan-cds commented Sep 8, 2022

Replaced core/jquery.cookie with core/js-cookie. As well as being deprecated, core/jquery.cookie also broke our cookie handling in the Full page alert banner.

@see https://www.drupal.org/node/3104677

Replaced core/jquery.cookie with core/js-cookie.  core/jquery.cookie broke our
cookie handling in addition to being deprecated.

@see https://www.drupal.org/node/3104677
Copy link
Contributor

@andybroomfield andybroomfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.
Shall we make this a release @Adnan-cds

@andybroomfield andybroomfield merged commit 4d61823 into 1.x Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants