Add the is_front template flag using path.matcher service #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybroomfield
force-pushed
the
fix/1.x-279-is-front-template-tag
branch
from
ae55b3a
to
1482d51
Compare
|
I think I need to add a test? But then I will merge this. |
Fix #279 Same method as page manager. This adds the is_front template flag to localgov alert banner for testing with twig. Will restore the default homepage class in the default template.
andybroomfield
force-pushed
the
fix/1.x-279-is-front-template-tag
branch
from
1482d51
to
22808fc
Compare
Checks the extra front page class is displayed on the alert banner template when on the front page, and not when on other pages.
|
Ready for re-review now the test is added. |
finnlewis
approved these changes
Jan 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #279
Same method as page manager.
This adds the is_front template flag to localgov alert banner for testing with twig.
Will restore the default homepage class in the default template.