Fix failing Hide alert banner test #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove testing in default localgov profile This is beause the profile is testing the home page, which with the profile is now the user login page now that localgovdrupal/localgov#613 is merged means that is the user login page.
|
This test fail
Is known and will raise as a new issue. |
|
Sorry Andy, I am slightly confused. Is this change not trying to resolve the test failure seen in the last test run? |
|
@Adnan-cds so this solves a new issue that was causing both Drupal 9. and Drupal 10 PHPunit tests to fail. |
|
Thanks @Adnan-cds i've merged this and opened a new issue for the Drupal 10 test fail as #284 |
1 similar comment
|
Thanks @Adnan-cds i've merged this and opened a new issue for the Drupal 10 test fail as #284 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #282
Remove testing in default localgov profile
This is beause the profile is testing the home page, which with the profile
is now the user login page now that
localgovdrupal/localgov#613
is merged means that is the user login page.