Add @requires group to the test that depends on group module. #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass on this, OK to merge and tag a release @andybroomfield ? |
Adnan-cds
approved these changes
Oct 12, 2023
finnlewis
deleted the
feature/297-skip-tests-where-dependency-not-present
branch
|
Thanks @Adnan-cds ! Just for the record, we were trying to supress the failing tests from here: https://github.com/localgovdrupal/localgov_project/actions/runs/6383368525/job/17380283376?pr=131 But it didn't seem to work. Drupal was still including the file and trying to extend the base class without group present. Requiring drupal/group in the test seems to have done the job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.