Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cs: strict types update #307

Merged
merged 1 commit into from
Feb 21, 2024
Merged

cs: strict types update #307

merged 1 commit into from
Feb 21, 2024

Conversation

andybroomfield
Copy link
Contributor

@andybroomfield andybroomfield commented Feb 21, 2024 •
edited

Same update as other repos.

Adnan-cds
Adnan-cds approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@Adnan-cds Adnan-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Test failures are unrelated.

@andybroomfield
Copy link
Contributor Author

Thanks @Adnan-cds

@andybroomfield andybroomfield merged commit bac4368 into 1.x Feb 21, 2024
6 of 8 checks passed
@andybroomfield andybroomfield deleted the fix/1.x/cs-update branch February 21, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adnan-cds Adnan-cds Adnan-cds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andybroomfield @Adnan-cds