Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Group alert banner query alteration #316

Conversation

Adnan-cds
Copy link
Contributor

Covers special case where there are no alert banners present in any of the microsites.

Cover the case where there are no alert banners present in any of the microsites.
@Adnan-cds
Copy link
Contributor Author

I have put some Band-aid around the code responsible for the fatal error.

@finnlewis finnlewis self-assigned this Apr 30, 2024
@stephen-cox stephen-cox self-requested a review April 30, 2024 11:48
Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I can now enable the group_alert_banner module and alert banners work as expected.

@finnlewis finnlewis merged commit f5a2587 into 1.x Apr 30, 2024
8 checks passed
@finnlewis finnlewis deleted the fix/315-fatal-database-error-trying-to-enable-group_alert_banner branch April 30, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants