Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.7.5 release #317

Merged
merged 4 commits into from
May 7, 2024
Merged

1.7.5 release #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f381708
Fix strict type errors
andybroomfield Mar 26, 2024
96154f8
Merge pull request #314 from localgovdrupal/fix/1.x-313-strict-types
andybroomfield Mar 27, 2024
0c23cd8
Fix: Group alert banner query alteration
Adnan-cds Apr 26, 2024
f5a2587
Merge pull request #316 from localgovdrupal/fix/315-fatal-database-er…
finnlewis Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion localgov_alert_banner.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ function localgov_alert_banner_theme_suggestions_localgov_alert_banner(array $va
function localgov_alert_banner_modules_installed($modules, $is_syncing) {

// Configure scheduled transitions if it's being installed.
if (in_array('scheduled_transitions', $modules)) {
if (in_array('scheduled_transitions', $modules, TRUE)) {
localgov_alert_banner_configure_scheduled_transitions();
}
}
Expand Down
11 changes: 7 additions & 4 deletions modules/group_alert_banner/group_alert_banner.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,13 @@ function group_alert_banner_query_entity_query_alter(AlterableInterface $query)
// The 'gcfd' table alias is set in
// Drupal\group\QueryAccess\EntityQueryAlter::doAlter() for the
// group_relationship_field_data table.
$query->where(
"(gcfd.entity_id IS NOT NULL AND gcfd.gid = :gid) OR gcfd.entity_id IS NULL",
[':gid' => $gid]
);
$table_aliases = $query->getTables();
if (array_key_exists('gcfd', $table_aliases)) {
$query->where(
'(gcfd.entity_id IS NOT NULL AND gcfd.gid = :gid) OR gcfd.entity_id IS NULL',
[':gid' => $gid]
);
}
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/src/Kernel/AlertBannerBlockOrderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class AlertBannerBlockOrderTest extends KernelTestBase {
* {@inheritdoc}
*/
public function setUp(): void {
parent::setup();
parent::setUp();

$this->installEntitySchema('content_moderation_state');
$this->installEntitySchema('user');
Expand Down
2 changes: 1 addition & 1 deletion tests/src/Kernel/SchedulingInstallTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class SchedulingInstallTest extends KernelTestBase {
* {@inheritdoc}
*/
public function setUp(): void {
parent::setup();
parent::setUp();

$this->installEntitySchema('workflow');
$this->installEntitySchema('user');
Expand Down
2 changes: 1 addition & 1 deletion tests/src/Kernel/SchedulingTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class SchedulingTest extends KernelTestBase {
* {@inheritdoc}
*/
public function setUp(): void {
parent::setup();
parent::setUp();

$this->installEntitySchema('content_moderation_state');
$this->installEntitySchema('user');
Expand Down
Loading