feat: use shared workflow #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix coding standard
stephen-cox
approved these changes
May 21, 2024
There was a problem hiding this comment.
Nice work @millnut! This is a huge simplification of the workflow management.
There maybe issues with the shared workflow when a module needs to support different versions of Drupal or LGD, but it's like this won't be required until we start adding Drupal 11 support and don't effect this repo now, so no action required, just flagging it for later.
|
Thank you @stephen-cox yep I've started to look at Drupal 11 and we have quite a few contrib modules that we are blocked on. We should be able to expand this workflow with optional inputs to cover those cases. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the module to use the shared workflow test file provided in the new workflow repo https://github.com/localgovdrupal/localgov_shared_workflows.
This will allow us to maintain a single workflow testing file which we can use across modules using the GitHub shared workflows functionality.
Once this has been reviewed I'll look at switching the other modules to this shared workflow.