Re-add the getCacheContexts method to block #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybroomfield
force-pushed
the
fix/1.x-327-alert-banner-block-cache-contexts
branch
from
8041e88
to
c45add6
Compare
andybroomfield
force-pushed
the
fix/1.x-327-alert-banner-block-cache-contexts
branch
from
c45add6
to
869dd13
Compare
andybroomfield
changed the title
rupertj
approved these changes
Jun 4, 2024
|
I've done some manual testing on this and while I couldn't recreate the bug locally, the code in this PR works as expected. (And page cache is on for me, for the record). I did find another cache bug - if you exclude a path, then view that path, then remove the exclusion, the block doesn't show until the cache is cleared, but that happens with or without this change, so it doesn't need to block this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #327
Part revert #325
Restores the getCacheContexts method as that is what is called each time to determine the cache contexts each time the block is rendered.