Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update View for compatibility with other types #96

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Update View for compatibility with other types #96

merged 1 commit into from
Dec 4, 2020

Conversation

tanc
Copy link
Contributor

@tanc tanc commented Dec 1, 2020

Has the following changes:

  1. Adds a 'Banner type' column showing the bundle.
  2. Removes 'created' column.
  3. Removes the filter restriction on bundle.
  4. Changes date to slightly shorter format (same as core content view).
  5. Adds sortable columns and responsive collapsing.
  6. Adds 'Banner type' exposed filter.

@tanc
Update View for compatibility with other types
4eadeac 
Adds a 'Banner type' column showing the bundle, removes 'created' column, removes the filter restriction on bundle, changes date to slightly shorter format (same as core content view), adds sortable columns and responsive collapsing.
@tanc
Copy link
Contributor Author

tanc commented Dec 1, 2020

Closes #95

@tanc
Copy link
Contributor Author

tanc commented Dec 1, 2020

image
Wide screen

@tanc
Copy link
Contributor Author

tanc commented Dec 1, 2020

image
Narrow screen demonstrating collapsed/hidden columns

@andybroomfield
Copy link
Contributor

Thanks @tanc this looks good.
I'll kick off the discussion on config update, however this should be simple enough to pass around the config change and just merge this? @finnlewis

andybroomfield
andybroomfield approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@andybroomfield andybroomfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and these changes work, thanks @tanc

I'm happy to merge this now, and pick up the config update in a new PR if we think that is needed.

@andybroomfield andybroomfield mentioned this pull request Dec 2, 2020
Closed
@andybroomfield andybroomfield merged commit ba99b9f into localgovdrupal:master Dec 4, 2020
@andybroomfield andybroomfield mentioned this pull request Jan 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybroomfield andybroomfield andybroomfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanc @andybroomfield