Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensures quick fact content is inside a <p> tag #617

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

markconroy
Copy link
Member

Closes #607

What does this change?

Our template "nearly" puts the text of a quick fact into p tags, but since we render {{ content.localgov_fact }} the render array produces a div which in turn means we render an empty p tag followed by the content.

This PR sorts that so that we render {{ content.localgov_fact.value }} instead so it goes inside the p tag.

How to test

Visit https://localgov.ddev.site/adult-health-and-social-care/another-service-landing-page/service-page and check that the content in the fact box is inside a p tag.

Accessibility

The original issue says "Key information is styled in a way that suggests importance but does not use appropriate semantic elements to convey its meaning.".

However, I am not sure what semantic elements to use except p for these elements. It's not clear in all circumstances (so we could make this generic) if any of the constituent parts should be headings or something else.


Thanks to Big Blue Door for sponsoring my time to work on this.

@msayoung
Copy link
Member

Hi @markconroy , this is great thanks.

I agree, its hard to know what to use which will make sense in all circumstances. I think generic <p> elements are ok.

@ekes ekes merged commit a1362aa into 1.x Sep 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing semantic structure in quick facts section
3 participants