Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drupal 10, PHP 8.2 and PHPStan issues #28

Closed
millnut opened this issue Sep 27, 2023 · 0 comments · Fixed by #29
Closed

Drupal 10, PHP 8.2 and PHPStan issues #28

millnut opened this issue Sep 27, 2023 · 0 comments · Fixed by #29

Comments

@millnut
Copy link
Member

millnut commented Sep 27, 2023

The work on localgovdrupal/localgov_project#131 has highlighted some PHP 8.2 and PHPStan issues which need fixing.

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_menu_link_group/src/Entity/LocalGovMenuLinkGroup.php                                                                                                                  
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  114    Method Drupal\localgov_menu_link_group\Entity\LocalGovMenuLinkGroup::set() should return $this(Drupal\localgov_menu_link_group\Entity\LocalGovMenuLinkGroup) but return statement is missing.  
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_menu_link_group/src/Form/LocalGovMenuLinkGroupForm.php                                                   
 ------ ---------------------------------------------------------------------------------------------------------------------------------- 
  194    Method Drupal\localgov_menu_link_group\Form\LocalGovMenuLinkGroupForm::save() should return int but return statement is missing.  
 ------ ----------------------------------------------------------------------------------------------------------------------------------
This was referenced Sep 27, 2023
Closed
Merged
@millnut millnut linked a pull request Oct 2, 2023 that will close this issue
fix: phpstan issues #29
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: phpstan issues localgovdrupal/localgov_menu_link_group
1 participant
@millnut