PHP 8.2 and PHPStan tracking

[millnut]

This issue will track and link to individual module tickets that require PHP 8.2 fixes as well as fixes related to a recent change to PHPStan level to match Drupal core in #131

• localgov_alert_banner - (fix: phpstan issues localgov_alert_banner#288)
• localgov_directories - (fix: phpstan issues localgov_directories#316)
• localgov_guides - (fix: phpstan issues localgov_guides#130)
• localgov_menu_link_group - (fix: phpstan issues localgov_menu_link_group#29)
• localgov_news - (fix: phpstan issues localgov_news#97)
• localgov_openreferral - (fix: phpstan issues localgov_openreferral#48)
• localgov_page_components - (fix: phpstan issues localgov_page_components#42)
• localgov_services - (fix: phpstan issues localgov_services#225)
• localgov_step_by_step - fixed by @Adnan-cds needs release
• localgov_subsites - (some issues already fixed by @Adnan-cds the rest in fix: phpstan issues localgov_subsites#128)
• localgov_workflows - (fix: phpstan issues localgov_workflows#68)
• localgov_base - (removes call to non nullible variable localgov_base#485)

[millnut]

@finnlewis @Adnan-cds all of the LocalGov Drupal code above now has PRs for PHP 8.2 compatibility and/or needs a release. I have tested all these locally by running the project and then installing the demo module to check for deprecations. @Adnan-cds, if you spot any more PHP 8.2 deprecations, please let me know.

Once each has been merged and then releases created for each module I should be able to test the project workflows again once #130 and #131 are merged.

There are some deprecations on contrib modules in PHP 8.2 that we depend on such as Pathauto and Entity Browser but I would rather they create new releases than add a patch within LocalGov Drupal.

Once this is complete, I can look into the Microsites project and check what PHP 8.2 deprecations might be there.

[finnlewis]

Amazing, thanks @millnut

Closing this.