-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: phpstan issues #288
fix: phpstan issues #288
Conversation
@@ -84,7 +84,7 @@ protected function prepareRevertedRevision(AlertBannerEntityInterface $revision, | |||
$revert_untranslated_fields = $form_state->getValue('revert_untranslated_fields'); | |||
|
|||
/** @var \Drupal\localgov_alert_banner\Entity\AlertBannerEntityInterface $default_revision */ | |||
$latest_revision = $this->AlertBannerEntityStorage->load($revision->id()); | |||
$latest_revision = $this->alertBannerEntityStorage->load($revision->id()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Casing fix as AlertBannerEntityRevisionRevertForm has this as alertBannerEntityStorage
not AlertBannerEntityStorage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass and looks good to me, thank @millnut !
Happy to have second opinion from @andybroomfield if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems sensible, and tested the functionality of the banner still works.
As an aside, the alert banner entity was genereted with an older version of the Drush entity generate plugin, and before that it used ECK, so we might want to look at regenerting that on the modern version later. |
Fix issues reported in #287