fix: phpstan issues #288
Merged
fix: phpstan issues #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millnut
commented
Sep 29, 2023
| @@ -84,7 +84,7 @@ protected function prepareRevertedRevision(AlertBannerEntityInterface $revision, | |||
| $revert_untranslated_fields = $form_state->getValue('revert_untranslated_fields'); | |||
|
|
|||
| /** @var \Drupal\localgov_alert_banner\Entity\AlertBannerEntityInterface $default_revision */ | |||
| $latest_revision = $this->AlertBannerEntityStorage->load($revision->id()); | |||
| $latest_revision = $this->alertBannerEntityStorage->load($revision->id()); | |||
There was a problem hiding this comment.
Casing fix as AlertBannerEntityRevisionRevertForm has this as alertBannerEntityStorage not AlertBannerEntityStorage
12 tasks
finnlewis
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Tests pass and looks good to me, thank @millnut !
Happy to have second opinion from @andybroomfield if needed.
andybroomfield
approved these changes
Oct 2, 2023
|
As an aside, the alert banner entity was genereted with an older version of the Drush entity generate plugin, and before that it used ECK, so we might want to look at regenerting that on the modern version later. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues reported in #287