Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 10, PHP 8.2 and PHPStan issues #67

Closed
millnut opened this issue Sep 27, 2023 · 0 comments · Fixed by #68
Closed

Drupal 10, PHP 8.2 and PHPStan issues #67

millnut opened this issue Sep 27, 2023 · 0 comments · Fixed by #68

Comments

@millnut
Copy link
Member

millnut commented Sep 27, 2023

The work on localgovdrupal/localgov_project#131 has highlighted some PHP 8.2 and PHPStan issues which need fixing.

 ------ ------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   modules/contrib/localgov_workflows/modules/localgov_review_date/src/Plugin/Field/FieldType/ReviewDateItem.php                             
 ------ ------------------------------------------------------------------------------------------------------------------------------------------ 
  51     Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$review.                               
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property                                                      
  51     Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$review_langcode.                      
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property                                                      
  51     Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$reviewed.                             
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property                                                      
  65     Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$reviewed.                             
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property                                                      
  65     Method Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::postSave() should return bool but return statement is missing.  
  70     Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$langcode.                             
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property                                                      
  78     Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$review.                               
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property                                                      
  87     Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$langcode.                             
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property                                                      
  96     Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$langcode.                             
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property                                                      
  113    Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$review.                               
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property                                                      
 ------ ------------------------------------------------------------------------------------------------------------------------------------------ 

 ------ -------------------------------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/tests/src/Functional/RequireLogTest.php                              
 ------ -------------------------------------------------------------------------------------------------------- 
  44     Access to an undefined property Drupal\Tests\localgov_workflows\Functional\RequireLogTest::$adminUser.  
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property                    
 ------ -------------------------------------------------------------------------------------------------------- 
@millnut millnut linked a pull request Oct 2, 2023 that will close this issue
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant