Feature/1.x/146 url aliases

[ekes]

Test with an update to HEAD of group_domain
and on a content type with url alias field enabled, which is all localgov types I found other than the new page one for which I'm making another PR.

Should allow alias to be set for the domain on which the content is being edited.
Will allow multiple aliases to be set should content be in multiple domains (current set up actually already allows two, one for the control site and one for the group domain in the case you are editing content that is in a domain group but doing so on the control domain).

[finnlewis]

On first test, I get an error when trying to add a url alias to a new directory channel.

I did a fresh install.
Created microsites 1
Created admin 1
Assigned admin1 to microsite 1
Logged into microsite 1
Create a directory facet type
Create a directory channel
Give it an alias of /contact
I get the following error:

The website encountered an unexpected error. Please try again later.

Drupal\Core\Entity\EntityMalformedException: The "node" entity cannot have a URI as it does not have an ID in Drupal\Core\Entity\EntityBase->toUrl() (line 161 of core/lib/Drupal/Core/Entity/EntityBase.php).
Drupal\domain_path\DomainPathHelper->submitEntityForm(Array, Object)
call_user_func_array(Array, Array) (Line: 114)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 52)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 592)
Drupal\Core\Form\FormBuilder->processForm('node_localgov_directory_form', Array, Object) (Line: 320)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 48)
Drupal\Core\Entity\EntityFormBuilder->getForm(Object, 'default', Array) (Line: 368)
Drupal\group\Entity\Controller\GroupContentController->createForm(Object, 'group_node:localgov_directory')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 564)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 158)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 709)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I'm out for a bit but can test more later this afternoon.

[ekes]

Confirmed: localgov_page works; localgov_directories_channel errors.

[ekes]

Confirmed: localgov_page works; localgov_directories_channel errors.

It's because it uses the two step form. Which in the first case we can fix by stopping using the two step form; but I'll see if I can't make a patch for domain_path to stop it trying to create an alias before the content is actually saved.

[ekes]

https://www.drupal.org/project/domain_path/issues/3293894

I guess, except for rewriting the module, we make some patch for ourselves that overrides the form alter in the case of what looks like a group two-step form and sets a message somewhere that it won't work with domain_path.

[stephen-cox]

Functionally this is working fine. Just a minor issue about where to put the permissions for this.

[ekes]

@stephen-cox assume we can get this is now localgovdrupal/localgov_microsites_group@454c848 is in

[stephen-cox]

Great - let's get it in