Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sets claro as admin theme #180

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Conversation

markconroy
Copy link
Member

Closes #179

@msayoung
Copy link
Member

How do people @stephen-cox @ekes @finnlewis feel about moving to Claro over Gin?

My preference for Claro is to do with button tab order - the save button comes after the form fields on a node edit form for example.

Also Claro is now stable, so that's cool.

@willguv
Copy link
Member

willguv commented Jul 13, 2022

@msayoung Gin seems to be well used now, so gets the thumbs up from me

The only problem I have is using it on a laptop screen - sometimes save button is obscured by the sidebar. Is this an issue for anyone else?

@ekes
Copy link
Member

ekes commented Jul 13, 2022

On the claro side it's simpler, and at least for the microsites it doesn't need deep admin integration as they only see the group admin pages and tabs we have produced.

@finnlewis
Copy link
Member

I like Gin, but there are a couple of anoying things about it (save button, tab order, permanent sidebar). But I'd like to get them logged and look at helping to make Gin better either way.

It might be interesting to do some AB testing at some point with some of our users.

Easy enough to switch between them so not too bothered at this stage if people want to focus on Claro for now.

@markconroy
Copy link
Member Author

I'd like us to use Claro for a sprint or two and see what we think of it, then move back to Gin if we decide it's a better admin theme.

Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it !

@markconroy markconroy merged commit 0ea792f into 1.x Jul 20, 2022
@finnlewis finnlewis deleted the feature/1.x/use-claro-for-admin-theme/179 branch January 16, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done sprint 8
Development

Successfully merging this pull request may close these issues.

Use Claro as admin theme
5 participants