Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a version in info.yml to avoid htmlspecialchars(): Passing null t… #322

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

finnlewis
Copy link
Member

…o parameter. Fixes #321

@finnlewis
Copy link
Member Author

So this PR fixes that error, but creates another coding standards error:

FILE: ...rofiles/contrib/localgov_microsites/localgov_microsites.info.yml
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | WARNING | Remove "version" from the info file, it will be added
   |         | by drupal.org packaging automatically
----------------------------------------------------------------------

So I wonder if we should commit this for now to remove the error on fresh installs, which is putting off people who are testing the system.

Also, why is this not a problem on LocalGov Drupal proper?

Any thoughts @msayoung @stephen-cox @ekes ?

@msayoung
Copy link
Member

Well, I confirm it suppresses the error.

Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be a core bug, so adding a version to the profile is not a good solution.

The latest patch on this issue seems to fix it https://www.drupal.org/project/drupal/issues/3255637

@finnlewis
Copy link
Member Author

Discussing with @stephen-cox - I think best to apply the patch to microsites for now to suppress the error.

@finnlewis
Copy link
Member Author

@stephen-cox changed the PR to use the patch and remove the VERSION parameter.

@finnlewis finnlewis merged commit d9f9b30 into 2.x Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.x] bug Deprecated function: htmlspecialchars():
3 participants