Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds core.extension.yml and field_settings config #35

Merged
merged 3 commits into from
May 5, 2022

Conversation

markconroy
Copy link
Member

Fixes #34

Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config/install/field_ui.settings.yml file should be removed. We also need to add modules not already required by other modules to the composer file. I can look at this later today

@@ -0,0 +1 @@
field_prefix: lgms_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to set this for everyone. It would be better if we use config overrides to set this. You can do this by adding the following to one of the sites settings.lando.php (or similar) files.

$config['field_ui.settings']['field_prefix'] = 'lgms_';

@markconroy
Copy link
Member Author

@stephen-cox are you okay to make the change you requested above while looking at this PR?

If adding new modules, can you also add twig_tweak to the composer.json file?

@stephen-cox
Copy link
Member

@markconroy A better way to enable modules during an install is to add them to the profiles info.yml file. I have removed the config file and added modules to the localgov_microsites.info.yml file.

How does this look to you?

@markconroy
Copy link
Member Author

Looks good, but we'll need to add twig_tweak to the composer.json. After that, all good to merge.

@markconroy
Copy link
Member Author

Sorry, just seen that twig_tweak was adding in another PR. This looks good to me now.

@markconroy markconroy merged commit 940a7fe into 1.x May 5, 2022
@finnlewis finnlewis deleted the feature/1.x-core-extension/34 branch January 16, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add core.extension.yml and field_settings config
2 participants