-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict the version of drupal/core to 9.4.x but not up to 9.5, so th… #352
Conversation
…at patches for 9.4 can be applied.
@stephen-cox I might be getting into a bit of a pickle here, can you advise or help? I do think we need to require a version of the localgov_microsites_project that restricts the drupal core version to 9.4, so see I am for now specifically requiring that branch on https://github.com/localgovdrupal/localgov_microsites/blob/2.0.x/.github/workflows/localgov_microsites.yml#L84 This now allows composer to crack on gathering requirements and the first part of the job appears to complete. But now, the subsequent jobs, Coding standards, Deprecated code and PHPUnit tests cannot find the ./html directory. Any idea what I've missed or messed? Cheers dude! |
@finnlewis I think I have unpickled the GitHub Actions in this PR The matrix for tests needs to be the same (there might be a better way to specify these) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to be pinning Drupal to 9.4 👍
Thanks so much @stephen-cox ! |
Restrict the version of drupal/core to 9.4.x but not up to 9.5, so that patches for 9.4 can be applied.