Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict the version of drupal/core to 9.4.x but not up to 9.5, so th… #352

Merged
merged 8 commits into from
Jan 18, 2023

Conversation

finnlewis
Copy link
Member

Restrict the version of drupal/core to 9.4.x but not up to 9.5, so that patches for 9.4 can be applied.

@finnlewis
Copy link
Member Author

@stephen-cox I might be getting into a bit of a pickle here, can you advise or help?

I do think we need to require a version of the localgov_microsites_project that restricts the drupal core version to 9.4, so see
https://github.com/localgovdrupal/localgov_microsites_project/blob/2.0.x/composer.json#L25-L26

I am for now specifically requiring that branch on https://github.com/localgovdrupal/localgov_microsites/blob/2.0.x/.github/workflows/localgov_microsites.yml#L84

This now allows composer to crack on gathering requirements and the first part of the job appears to complete.

But now, the subsequent jobs, Coding standards, Deprecated code and PHPUnit tests cannot find the ./html directory.

Any idea what I've missed or messed?

Cheers dude!

@stephen-cox
Copy link
Member

@finnlewis I think I have unpickled the GitHub Actions in this PR

The matrix for tests needs to be the same (there might be a better way to specify these)

Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be pinning Drupal to 9.4 👍

@finnlewis
Copy link
Member Author

Thanks so much @stephen-cox !

@finnlewis finnlewis merged commit 4ad59a0 into 2.0.x Jan 18, 2023
@stephen-cox stephen-cox deleted the feature/2.0.x/drupal-core-restriction branch July 31, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants