Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create default domain record during a site install #90

Merged
merged 2 commits into from
May 20, 2022

Conversation

stephen-cox
Copy link
Member

This PR adds a hostname field to the site instal config page and then uses this to create the default domain record.

When running a dush site-install it will use the --uri parameter to create the default domain record (there's no need to add this when running Drush in Lando).

Closes #75

Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both drush & ui install (wow I've not done one of those before).

it should maybe validate the hostname entered? I think domain does that.
However I tested it with a bogus one and it didn't break things.

@stephen-cox stephen-cox merged commit 3fedad0 into 1.x May 20, 2022
@stephen-cox stephen-cox deleted the feature/75-defualt-domain branch May 20, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set default domain record on install.
2 participants