Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config override for the wysiwyg in microsites #99

Merged
merged 1 commit into from
May 24, 2022

Conversation

msayoung
Copy link
Member

Not sure if this is the best way to do it, but I've copied the config from localgov_media and put it in localgov_microsites profile.

(it just removes H1 as an option in the wysiwyg)

@ekes
Copy link
Member

ekes commented May 23, 2022

We depend on localgov_media so we should get the config from localgov_media? We don't?

Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. @ekes if you think we need an issue to review where this config comes from, let's create one.

@ekes
Copy link
Member

ekes commented May 24, 2022

This works for me. @ekes if you think we need an issue to review where this config comes from, let's create one

Sure. So the question is if localgov_media works in the localgov profile, why doesn't it work in the localgov_microsites profile?

I am correct here that we are just duplicating the same configuration in two places for microsites?

@msayoung
Copy link
Member Author

No @ekes - I'm changing it for microsites. sorry that wasn't clear

@msayoung msayoung merged commit 69aba8e into 1.x May 24, 2022
@finnlewis finnlewis deleted the feature/1.x/remove-h1-#63 branch January 16, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants