Add cache tags for all status nodes to service status message block #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-cox
changed the title
|
@dedavidson are you able to test this and see if it works for you? |
|
Would like someone to manually test this. |
|
Will get this tested - sorry trying to clear decks before Xmas! |
|
Hopefully we can get this merged next MT? I kinda wish I hadn't looked. But I did and the update f4d7c12 should make it even closer to correct, even though I can't quite get the tests to play for all the variations. Also should we manually drop 9.4 from the test matrix? Or should it be done with the script? |
|
Bump for MT (also rerunning tests). |
|
@ekes is happy! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229