Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WSOD on sublanding topic list when referenced term is deleted #255

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix WSOD on sublanding topic list when referenced term is deleted #255

merged 1 commit into from
May 14, 2024

Conversation

andybroomfield
Copy link
Contributor

Fix #254

Fetch the label using in a NULL safe way.

@andybroomfield
Fix WSOD on sublanding topic list when referenced term is deleted
164524c 
Fix #254

Fetch the label using in a NULL safe way.
@andybroomfield
Copy link
Contributor Author

andybroomfield commented Apr 30, 2024 •
edited
Loading

Note: This uses a Null safe operator, so PHP 8 only.
Happy to amend if we need PHP 7.4 support.

@andybroomfield
Copy link
Contributor Author

This could do with a look at the next merge Tuesday, as it cropped up a few times for us @finnlewis @stephen-cox @ekes.

ekes
ekes approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're already using PHP8 features generally, and the NULL safe operator in particular, elsewhere.

Failing test is D9 will be fixed with #257 which I'll get approved too.

@finnlewis finnlewis merged commit d12758c into 2.x May 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekes ekes ekes approved these changes

@finnlewis finnlewis Awaiting requested review from finnlewis

@stephen-cox stephen-cox Awaiting requested review from stephen-cox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WSOD on sublanding page / topic list builder if referencing a deleted topic
3 participants
@andybroomfield @ekes @finnlewis