Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a fix to etmerc gatg increasing accuracy of etmerc #13

Closed
wants to merge 3 commits into from

Conversation

halset
Copy link
Contributor

@halset halset commented Jun 12, 2018

An error in my etmerc gatg port caused bad accuracy. This patch fixes that problem.

halset added a commit to ElectronicChartCentre/ecc-mvn-repo that referenced this pull request Jun 12, 2018
@halset halset changed the title a fix to etmerc gatg increesing accuracy of etmerc a fix to etmerc gatg increasing accuracy of etmerc Jun 12, 2018
@halset
Copy link
Contributor Author

halset commented Jun 12, 2018

Any tips on how I can fix the "invalid Signed-off-by footers" problem?

@pomadchin
Copy link
Member

pomadchin commented Jun 12, 2018

Hey @halset, you have to sign off all your commits. To do it just add a special flag to the commit cmd: git commit -s -m "message"

For instance to fix you last commit do git commit --amend -s.

https://github.com/locationtech/proj4j/blob/master/CONTRIBUTING.md#sign-off-on-commits-and-filing-a-cla

@halset
Copy link
Contributor Author

halset commented Jun 12, 2018

Thanks, @pomadchin ! Closing this now and trying again in #14.

@halset halset closed this Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants