Fix UTM, LCC, Krovak and Stere projections #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect proj4-epsg tests and update them up to date
pomadchin
commented
Apr 7, 2021
| @@ -100,6 +100,66 @@ public void testExplicitTransform() { | |||
| assertTrue(isInTolerance(p2, 33, 42, 0.000001)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void lccToUtmBidirectionalTransform() { | |||
There was a problem hiding this comment.
This manual test was added, since it was the initial test case that led into this issue discovery.
Comment on lines
+183
to
+195
| // this test is asjusted to match proj4s behavior | ||
| checkTransformAndInverse( | ||
| "EPSG:4326", -126.54, 54.15, | ||
| "EPSG:3005", 964813.103719, 1016486.305862, | ||
| 0.0001, 0.2 * APPROX_METRE_IN_DEGREES); | ||
|
|
||
| checkTransformAndInverse( | ||
| "EPSG:32633", 249032.839239894, 7183612.30572229, | ||
| "EPSG:4326", 9.735465995810884, 64.68347938257097, | ||
| "EPSG:4326", 9.735465995870696, 64.68347938261206, | ||
| 0.000001, 0.3 * APPROX_METRE_IN_DEGREES); | ||
|
|
||
| checkTransformAndInverse( | ||
| "EPSG:32636", 500000, 4649776.22482, | ||
| "EPSG:32636", 500000, 4649776.224819178, |
There was a problem hiding this comment.
Slighlty adjusted test, it matches Pro4JS behavior.
| MetaCRSTestFileReader reader = new MetaCRSTestFileReader(file); | ||
| List<MetaCRSTestCase> tests = reader.readTests(); | ||
| for (MetaCRSTestCase test : tests) { | ||
| Assert.assertTrue(runTest(test)); |
There was a problem hiding this comment.
Oops, tests were not checking the exit code before this PR :D
pomadchin
commented
Apr 7, 2021
| register("urmfps", UrmaevFlatPolarSinusoidalProjection.class, "Urmaev Flat-Polar Sinusoidal"); | ||
| register("utm", TransverseMercatorProjection.class, "Universal Transverse Mercator (UTM)"); | ||
| register("utm", ExtendedTransverseMercatorProjection.class, "Universal Transverse Mercator (UTM)"); |
There was a problem hiding this comment.
That's the UTM projection fix itself.
pomadchin
commented
Apr 7, 2021
pomadchin
changed the title
pomadchin
changed the title
echeipesh
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test resurrection results
Before this PR proj4-epsg.csv contained the following amount of tests:
After:
ExtendedTransverseMercatorProjection)UPD
After (with LCC projection fix):
UPD2
After (with Krovak projection fix):
Closes #25
Closes #58
Closes #61