Move all core resources to epsg submodule #95
Conversation
|
🤦 I'll double check files contents with the pre 1.2.x version. Also there should be no dependency between core and epsg I think, or it should be a provided / optional / test one. |
|
Good catch, I went too fast when reporting my changes in the fork... I amended the commit. |
|
Could you also sign ECA to make Eclipse ECA Validator happy? This is also not really a code change so I think it is fine to merge it as is. |
|
Thank you for helping with it! I definitely needed a second pair of eyes. 👍 |
|
I signed the Eclipse Contributor Agreement, but there is still a problem with the "Eclipse Foundation Specification Project". Any idea where this check comes from? |
|
Quick note on the −16,166 lines: many resources files were duplicated in the java and test directory. |
|
@bchapuis the actual error is |
|
Sorry, I have not been able to sort this out. I don't want to slow you down so feel free to ignore this PR. For future contributions, is there an administrative contact at the eclipse foundation that may help sorting this kind of issue? |
|
Hey @bchapuis I think just hit the repo maintainers, but if you want to go full hardcore its usually EMO (emo (at) eclipse.org), more contacts can be found here https://www.eclipse.org/org/foundation/contact.php |
|
Thanks for you contribution! ECA is green as well. |
pomadchin
changed the title
… version 1.2.2, and generated a new output csv file "CrsTransformationAdapterProj4jLocationtech_version_1.2.2.csv" with lots of coordinate transformations created by this new version, which can be compared (e.g. by using WinMerge) with the csv file from the previously used version i.e. the csv file "CrsTransformationAdapterProj4jLocationtech_version_1.1.4.csv" (and there were no differences) Also added a new dependency "proj4j-epsg" and updated the license text because of this new dependency. Below is some text copied from https://github.com/locationtech/proj4j : "Important! As of 1.2.2 version, proj4-core contains no EPSG Licensed files. In order to make proj4j properly operate, it makes sense to consider proj4-epsg dependency usage." Some related "locationtech/proj4j" issues and pull requests: "Proj4j should not use the Apache License if it contains the EPSG data set" locationtech/proj4j#90 "Split projects into proj4j and proj4j-epsg" locationtech/proj4j#92 "Move all core resources to epsg submodule" locationtech/proj4j#95
No description provided.