Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Provide cargo suited examples #355

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

AiyionPrime
Copy link
Contributor

@AiyionPrime AiyionPrime commented Jul 1, 2024

Currently blocked by

This PR drafts how to migrate the examples from samples workspaces to lib/examples to use cargos features for working and testing with them.

This eventually closes #354

@AiyionPrime AiyionPrime changed the title feat: Provide cargo suited examples feat!: Provide cargo suited examples Jul 1, 2024
@AiyionPrime

This comment was marked as outdated.

@AiyionPrime AiyionPrime force-pushed the feat/cargo_examples branch 3 times, most recently from 7acb692 to 31d3254 Compare July 30, 2024 14:12
which removes it as workspace and allows cargo to index it.
which removes it as workspace and allows cargo to index it.
which removes it as workspace and allows cargo to index it.
which removes it as workspace and allows cargo to index it.
which removes it as workspace and allows cargo to index it.
which removes it as workspace and allows cargo to index it.
which removes it as workspace and allows cargo to index it.
@AiyionPrime
Copy link
Contributor Author

That should be it.

@AiyionPrime AiyionPrime marked this pull request as ready for review July 31, 2024 23:10
@AiyionPrime
Copy link
Contributor Author

I expect each of these commits to pass the pipeline on its own.
@locka99 Should I split this into different PRs to migrate each sample on its own?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples might better reside in an examples folder
1 participant