Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loco generate reqeust test template use pkg_name #133

Merged

Conversation

fan-tastic-z
Copy link
Contributor

fix #132

@jondot
Copy link
Contributor

jondot commented Dec 12, 2023

You probably want to add pkg_name to the template context, like done here:

https://github.com/loco-rs/loco/blob/master/src/gen/mod.rs#L111

@fan-tastic-z
Copy link
Contributor Author

template context

thanks,I update pr code

@fan-tastic-z fan-tastic-z force-pushed the fix-loco-generate-request-test-template branch from 84bfcf7 to 6fe73d4 Compare December 12, 2023 11:32
@jondot
Copy link
Contributor

jondot commented Dec 12, 2023

@fan-tastic-z thanks, there is one additional place here: https://github.com/loco-rs/loco/blob/master/src/gen/scaffold.rs#L52

@jondot jondot merged commit 5657174 into loco-rs:master Dec 12, 2023
10 checks passed
@fan-tastic-z fan-tastic-z deleted the fix-loco-generate-request-test-template branch December 12, 2023 12:39
@fan-tastic-z
Copy link
Contributor Author

@jondot Thank you very much for your help. I just started learning Rust and found loco to be a great project. I hope I can learn Rust better through loco.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate code request_test template error
2 participants