Refactor code base #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to it's own trait
Replace boilerplate/dummy content with bare minimum of context for the package.
Required: - Charcoal v4.0 - PHP CodeSniffer v3.8 - PHP Coveralls v2.2 - PHPStan v1.10 - PHPUnit v9.5 - Psalm v5.17 - seld/jsonlint v1.10 Changed: - Increased branch-alias to 1.x. - Updated and renamed Composer scripts.
Add production requirements for specific packages of Charcoal: Config, Core, Object, Property, Translator.
Changed: - Remove ACL permission to allow projects to apply their own permissions pattern. - Add default priority to sort this item at a mid-point in a project's menu collection. - Fix French localization.
Changed: - Rename namespace from "consent" to "cookie-consent" to avoid conflicts. - Rename button label identifiers and localizations to match with vanilla-cookieconsent's labeling.
From `ConsentServiceProvider ` to `CookieConsentServiceProvider` to match equivalent module and to distinguish from consent modal.
Structure of the modeling and presentation is based on locomotivemtl/wp-plugin-cookie-consent. Changed: - Moved model structures from `Structure\Consent` to `Structure`. - Removed model `PreferenceSectionWithCategory`. - Renamed model `PreferenceSection` to `Section` and have `ConsentModal` and `PreferencesModal` extend it. - Replaced class `ConsentService` and transformers with `CookieConsentManager`. - Renamed model `Consent` to `Disclosure` to distinguish from consent modal and to better encompass all editable options. - Rename model `CookieCategory` to `Category`. - Simplify TinyMCE options.
Changes: - Add consent modal `footer` field - Remove `active` and `label` field from `link` model - Update the parsePlaceHolders `count` parameter to support a persistent container - Update and add new translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.