chore(dependencies): bump flowbite-react and fix Datepicker #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhennig
changed the title
|
Nice, this looks good, I tested it on the preview (in the future remember to add that label immediately to save reviewers the waiting time ;) ) |
corneliusroemer
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3049
https://fix-datetimepicker-bump.loculus.org
Summary
Bump the flowbite-react dependency and incorporate the breaking Datepicker changes. The Datepicker now supports null values, which is actually not good for our use cases. We do not display the clear button in our cases, so we can ignore the typed null values; they will never come. To be defensive about it I added a warning logging output in case a null value is encountered in the onChange handler.
Screenshot
Submit view
Edit view
PR Checklist
All necessary documentation has been adapted.