Merge pull request #2999 from andrewbaldwin44/bugfix/download-links

Webui links should be relative
locustio · Nov 28, 2024 · de9af6a · de9af6a
2 parents fceb6d3 + 1c7d780
commit de9af6a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/locust/webui/src/components/Reports/Reports.test.tsx b/locust/webui/src/components/Reports/Reports.test.tsx
@@ -10,7 +10,7 @@ describe('Reports', () => {
     const link = getByText('Download requests CSV');
 
     expect(link).toBeTruthy();
-    expect(link.getAttribute('href')).toBe('/stats/requests/csv');
+    expect(link.getAttribute('href')).toBe('./stats/requests/csv');
   });
 
   test('renders a link to download failures CSV', () => {
@@ -19,7 +19,7 @@ describe('Reports', () => {
     const link = getByText('Download failures CSV');
 
     expect(link).toBeTruthy();
-    expect(link.getAttribute('href')).toBe('/stats/failures/csv');
+    expect(link.getAttribute('href')).toBe('./stats/failures/csv');
   });
 
   test('renders a link to download exceptions CSV', () => {
@@ -28,7 +28,7 @@ describe('Reports', () => {
     const link = getByText('Download exceptions CSV');
 
     expect(link).toBeTruthy();
-    expect(link.getAttribute('href')).toBe('/exceptions/csv');
+    expect(link.getAttribute('href')).toBe('./exceptions/csv');
   });
 
   test('renders a link to download stats history CSV when enabled', () => {
@@ -41,7 +41,7 @@ describe('Reports', () => {
     const link = getByText('Download full request statistics history CSV');
 
     expect(link).toBeTruthy();
-    expect(link.getAttribute('href')).toBe('/stats/requests_full_history/csv');
+    expect(link.getAttribute('href')).toBe('./stats/requests_full_history/csv');
   });
 
   test('does not render a link to download stats history CSV when disabled', () => {
@@ -60,7 +60,7 @@ describe('Reports', () => {
     const link = getByText('Download Report');
 
     expect(link).toBeTruthy();
-    expect(link.getAttribute('href')).toBe('/stats/report?theme=dark');
+    expect(link.getAttribute('href')).toBe('./stats/report?theme=dark');
   });
 
   test('renders a link to download the report in light mode when theme is light', () => {
@@ -71,7 +71,7 @@ describe('Reports', () => {
     const link = getByText('Download Report');
 
     expect(link).toBeTruthy();
-    expect(link.getAttribute('href')).toBe('/stats/report?theme=light');
+    expect(link.getAttribute('href')).toBe('./stats/report?theme=light');
   });
 
   test('renders links to download extended CSV files', () => {

diff --git a/locust/webui/src/components/Reports/Reports.tsx b/locust/webui/src/components/Reports/Reports.tsx
@@ -15,24 +15,24 @@ function Reports({
   return (
     <List sx={{ display: 'flex', flexDirection: 'column' }}>
       <ListItem>
-        <Link href='/stats/requests/csv'>Download requests CSV</Link>
+        <Link href='./stats/requests/csv'>Download requests CSV</Link>
       </ListItem>
       {statsHistoryEnabled && (
         <ListItem>
-          <Link href='/stats/requests_full_history/csv'>
+          <Link href='./stats/requests_full_history/csv'>
             Download full request statistics history CSV
           </Link>
         </ListItem>
       )}
       <ListItem>
-        <Link href='/stats/failures/csv'>Download failures CSV</Link>
+        <Link href='./stats/failures/csv'>Download failures CSV</Link>
       </ListItem>
       <ListItem>
-        <Link href='/exceptions/csv'>Download exceptions CSV</Link>
+        <Link href='./exceptions/csv'>Download exceptions CSV</Link>
       </ListItem>
       <ListItem>
         <Link
-          href={`/stats/report?theme=${isDarkMode ? THEME_MODE.DARK : THEME_MODE.LIGHT}`}
+          href={`./stats/report?theme=${isDarkMode ? THEME_MODE.DARK : THEME_MODE.LIGHT}`}
           target='_blank'
         >
           Download Report