Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError: 'CompatRequest' object has no attribute 'type' in Cookiejar #1139

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Fix AttributeError: 'CompatRequest' object has no attribute 'type' in Cookiejar #1139

merged 1 commit into from
Nov 11, 2019

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented Nov 11, 2019

Fixes #1138

@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #1139 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
- Coverage    75.5%   75.46%   -0.05%     
==========================================
  Files          18       18              
  Lines        1817     1818       +1     
  Branches      276      276              
==========================================
  Hits         1372     1372              
  Misses        382      382              
- Partials       63       64       +1
Impacted Files Coverage Δ
locust/contrib/fasthttp.py 91.22% <100%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba265c5...1f4106f. Read the comment docs.

@heyman
Copy link
Member

heyman commented Nov 11, 2019

LGTM

@cyberw cyberw merged commit b1af7de into locustio:master Nov 11, 2019
@cyberw cyberw deleted the workaround-for-fasthttplocust-failing-on-cookies branch January 29, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated secure requests with FastHttpLocust crashes in cookie management
2 participants