Ensure runner.quit finishes even when users are broken #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberw
deleted the
ensure-runner.quit-finishes-even-when-users-are-broken
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #1726
This should change it from throwing an exception (and thus failing to stop), to instead logging an error message and then moving on (havent been able to test it 100% though). May give us some more info for a proper fix as well.
[2021-03-11 12:54:24,150] lafp-mac-JG5J.int.svenskaspel.se/INFO/locust.main: Shutting down (exit code 0), bye.
[2021-03-11 12:54:24,150] lafp-mac-JG5J.int.svenskaspel.se/INFO/locust.main: Cleaning up runner...
[2021-03-11 12:54:24,150] lafp-mac-JG5J.int.svenskaspel.se/ERROR/locust.runners: Found a user that didnt have proper args <Greenlet "Greenlet-0" at 0x112c863b0: run_user(<player_settings.WebUser object at 0x112b1f650>)>