-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #2955 Allow to exclude some statistics from aggregation #2956
base: master
Are you sure you want to change the base?
Conversation
4c04514
to
faeef8e
Compare
If anyone has ideas why Mypy step fails, the error seems unrelated to the change, at least the line for which the error is triggered wasn't updated by this PR at all. |
Does mypy (using 1.11.2) work for you locally? |
@cyberw no it seems to be the same issue, it's really not clear why this tool is failing especially as those lines are not touched by this PR |
Not sure what the typing issue is, but passing the whole environment into the RequestsStats constructor is awkward. Maybe just pass the exclude_from_aggregation regex? |
aae127a
to
c7be3db
Compare
@cyberw thanks for your feedback, I have updated it now and also changed to allow setting that via command arguments. |
Can you try grabbing this change: 74d5de4 It seems to have been a "real" issue with the type hints in the code, but I still don't understand why your PR exposed it :) |
Here is a sample implementation allowing to set the
--exclude-from-aggregation
argument option.locust --exclude-from-aggregation "CUSTOM"
Note:
environment.stats
object property exclude_from_aggregation