Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading of a locustfile with multiple dots in filename #941

Merged

Conversation

raiyankamal
Copy link
Contributor

@raiyankamal raiyankamal commented Jan 7, 2019

Fix for #940
Uses methods from the importlib (python 3) and imp (python 2.7) modules to allow loading of files with multiple dots in the filename.

@raiyankamal raiyankamal changed the title Allow loading of modules with multiple dots in filename Allow loading of a locustfile with multiple dots in filename Jan 7, 2019
@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #941 into master will increase coverage by 0.83%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
+ Coverage   66.55%   67.38%   +0.83%     
==========================================
  Files          14       14              
  Lines        1438     1447       +9     
  Branches      226      226              
==========================================
+ Hits          957      975      +18     
+ Misses        430      418      -12     
- Partials       51       54       +3
Impacted Files Coverage Δ
locust/main.py 33.18% <100%> (+7.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8eb37...17eb8f2. Read the comment docs.

@raiyankamal
Copy link
Contributor Author

Closing because incomplete.

@raiyankamal raiyankamal closed this Jan 8, 2019
@raiyankamal
Copy link
Contributor Author

Reopening PR after adding unit tests and correcting code for loading locustfile.

@raiyankamal raiyankamal reopened this Jan 8, 2019
@raiyankamal raiyankamal force-pushed the 940/bug/filename-with-multiple-dots branch from 9c66fa8 to 7194ba1 Compare January 8, 2019 04:37
@cgoldberg cgoldberg merged commit e3a74db into locustio:master Jan 19, 2019
@cgoldberg
Copy link
Member

thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants