fix: ensure that Cluster CR reports control plane as ready

This is done by adding the controlPlaneRef to the Cluster CR
and by adding .status.initialized field to vcluster CRD

api/v1alpha1/vcluster_types.go

@@ -51,6 +51,10 @@ type VClusterStatus struct {
 	// +optional
 	Ready bool `json:"ready"`
 
+	// Initialized defines if the virtual cluster control plane was initialized.
+	// +optional
+	Initialized bool `json:"initialized"`
+
 	// Phase describes the current phase the virtual cluster is in
 	// +optional
 	Phase VirtualClusterPhase `json:"phase,omitempty"`

config/crd/bases/infrastructure.cluster.x-k8s.io_vclusters.yaml

@@ -124,6 +124,10 @@ spec:
                   - type
                   type: object
                 type: array
+              initialized:
+                description: Initialized defines if the virtual cluster control plane
+                  was initialized.
+                type: boolean
               message:
                 description: Message describes the reason in human readable form why
                   the cluster is in the currrent phase

controllers/vcluster_controller.go

@@ -347,6 +347,9 @@ func (r *VClusterReconciler) syncVClusterKubeconfig(ctx context.Context, vCluste
 
 		conditions.MarkTrue(vCluster, v1alpha1.ControlPlaneInitializedCondition)
 	}
+	// setting .Status.Initialized outside of the condition above to ensure
+	// that it is set on old CRs, which were missing this field, as well
+	vCluster.Status.Initialized = true
 
 	// write kubeconfig to the vcluster.Name+"-kubeconfig" Secret as expected by CAPI convention
 	kubeConfig, err := GetVClusterKubeConfig(ctx, r.Client, vCluster)

templates/cluster-template.yaml

@@ -7,6 +7,10 @@ spec:
     apiVersion: infrastructure.cluster.x-k8s.io/v1alpha1
     kind: VCluster
     name: ${CLUSTER_NAME}
+  controlPlaneRef:
+    apiVersion: infrastructure.cluster.x-k8s.io/v1alpha1
+    kind: VCluster
+    name: ${CLUSTER_NAME}
 ---
 apiVersion: infrastructure.cluster.x-k8s.io/v1alpha1
 kind: VCluster