Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): add unit-test to vcluster controller #49

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

narcis96
Copy link
Contributor

No description provided.

@narcis96 narcis96 force-pushed the narcis/controller_testing branch 5 times, most recently from 3e6dfb6 to 5736bac Compare March 4, 2024 13:18
@narcis96 narcis96 changed the title [WIP] chore(test): add tests to vcluster controller chore(test): add unit-test to vcluster controller Mar 4, 2024
@narcis96 narcis96 force-pushed the narcis/controller_testing branch 3 times, most recently from e903c57 to 60018af Compare March 4, 2024 13:48
Copy link
Member

@ThomasK33 ThomasK33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the fake helm client struct name, apart from that lgtm

test/controllerstest/mock.go Outdated Show resolved Hide resolved
@narcis96 narcis96 merged commit 416cd03 into loft-sh:main Mar 5, 2024
3 checks passed
@narcis96 narcis96 deleted the narcis/controller_testing branch March 5, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants