fix: improve handling of old host CRDs #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always set
.Spec.PreserveUnknownFields = false
because that is needed for compatibility withapiextensions.k8s.io/v1
, as mentioned in the docs - https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#field-pruningRelease note:
The
spec.preserveUnknownFields
field of CRDs copied from the host cluster will always be set tofalse
This fixes the problem reported by the user here - https://loft-sh.slack.com/archives/C01N273CF4P/p1669781095611459