Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve patcher & crd sync #1930

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

FabianKramm
Copy link
Member

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

Please provide a short message that should be published in the vcluster release notes

  • Prints what exactly has been patched in debug mode
  • Do not run initializers in parallel as this is unexpected and can lead to race conditions in integration / plugins

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for vcluster-docs canceled.

Name Link
🔨 Latest commit db3dfe0
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/669510344008ff000848a84c

@@ -126,23 +126,19 @@ func ExecuteInitializers(controllerCtx *config.ControllerContext, syncers []sync
registerContext := util.ToRegisterContext(controllerCtx)

// execute in parallel because each one might be time-consuming
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should probably be updated too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep true

@FabianKramm FabianKramm merged commit c62804a into loft-sh:main Jul 15, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants