Events patcher #1940
Merged
Events patcher #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
facchettos
force-pushed
the
events-patcher
branch
from
2f96dd7 to
d96f595
Compare
FabianKramm
reviewed
Jul 16, 2024
FabianKramm
reviewed
Jul 17, 2024
| @@ -124,7 +111,9 @@ var _ syncer.ToVirtualSyncer = &eventSyncer{} | |||
|
|
|||
| func (s *eventSyncer) SyncToVirtual(ctx *synccontext.SyncContext, pObj client.Object) (ctrl.Result, error) { | |||
| // build the virtual event | |||
| vObj, err := s.buildVirtualEvent(ctx.Context, pObj.(*corev1.Event)) | |||
| vObj := pObj.DeepCopyObject().(*corev1.Event) | |||
| vObj.ResourceVersion = "" | |||
There was a problem hiding this comment.
This should be translate.ResetObjectMetadata(vObj), but since this is called in translateEvent, is that even necessary at all?
There was a problem hiding this comment.
so if we don't call it manually beforehand, the resource version will still be set because vObj contains the resource version of the physical object at that point.
https://github.com/loft-sh/vcluster/pull/1940/files#diff-841ade67d794007be038e9be601ecb81f2e9b7b2e5b10ec260d13345b54294c1R43 this is where we would be overwriting it. To avoid doing that we should have a parameter to know whether we are creating the object or not. I believe it's slightly worse than the current solution
facchettos
force-pushed
the
events-patcher
branch
from
15ea55d to
07d7275
Compare
FabianKramm
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)part of eng-4141
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...
What else do we need to know?