Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: delete object if it was deleted on host #1948

Merged
merged 1 commit into from
Jul 18, 2024
Merged

refactor: delete object if it was deleted on host #1948

merged 1 commit into from
Jul 18, 2024

Conversation

FabianKramm
Copy link
Member

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

Changes within this PR:

  • Adds detection for delete events within the syncers
  • Deletes virtual objects if the host object was deleted
  • Combines NamespacedTranslator and ClusterTranslator into GenericTranslator

@FabianKramm FabianKramm requested a review from ThomasK33 July 18, 2024 09:46
@netlify Netlify
Copy link

netlify bot commented Jul 18, 2024 •
edited
Loading

✅ Deploy Preview for vcluster-docs canceled.

Name Link
🔨 Latest commit b8f4b77
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/6698eecd73aab10008bcbdae

@FabianKramm FabianKramm force-pushed the mappings branch 2 times, most recently from 89f32f5 to 9599d14 Compare July 18, 2024 09:51
@FabianKramm FabianKramm force-pushed the mappings branch 6 times, most recently from 801ef42 to 7bdb501 Compare July 18, 2024 10:29
@FabianKramm FabianKramm merged commit 8eb07b4 into loft-sh:main Jul 18, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasK33 ThomasK33 ThomasK33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabianKramm @ThomasK33