feat: add name & labels mapping store #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
FabianKramm
force-pushed
the
mappings-store
branch
12 times, most recently
from
86f4e38 to
c55f5d5
Compare
FabianKramm
force-pushed
the
mappings-store
branch
from
c55f5d5 to
f556163
Compare
FabianKramm
force-pushed
the
mappings-store
branch
10 times, most recently
from
e3726f4 to
d199c06
Compare
FabianKramm
force-pushed
the
mappings-store
branch
from
d199c06 to
291dc9f
Compare
FabianKramm
force-pushed
the
mappings-store
branch
2 times, most recently
from
94e8583 to
fc137d5
Compare
facchettos
reviewed
Jul 30, 2024
| @@ -143,6 +142,10 @@ func (s *importer) Syncer() syncertypes.Sync[client.Object] { | |||
| return syncer.ToGenericSyncer[*unstructured.Unstructured](s) | |||
| } | |||
|
|
|||
| func (s *importer) Migrate(_ *synccontext.RegisterContext, _ synccontext.Mapper) error { | |||
There was a problem hiding this comment.
Migrate replaces basically the index we had before. Since we startup without "knowing" anymore what objects were how translated, we have the migrate function that initially populates the store with the virtual <-> host mappings
There was a problem hiding this comment.
Maybe we can call the function MigrateMappings to make this more clear
facchettos
reviewed
Jul 30, 2024
| @@ -16,8 +16,8 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/client" | |||
| ) | |||
|
|
|||
| func New(ctx *synccontext.RegisterContext) (syncertypes.Object, error) { | |||
| mapper, err := ctx.Mappings.ByGVK(mappings.CSIDrivers()) | |||
| func New(_ *synccontext.RegisterContext) (syncertypes.Object, error) { | |||
There was a problem hiding this comment.
can't we just remove the parameter?
There was a problem hiding this comment.
this needs to adhere to the create syncer type function that uses this parameter for other syncers
facchettos
reviewed
Jul 30, 2024
| PermitWithoutStream: true, | ||
| Endpoints: endpoints, | ||
| Context: ctx, | ||
| DialTimeout: 5 * time.Second, |
There was a problem hiding this comment.
This causes issues if you just want to query etcd for values as its trying to reach all peers
facchettos
reviewed
Jul 30, 2024
facchettos
reviewed
Jul 30, 2024
facchettos
reviewed
Jul 30, 2024
facchettos
reviewed
Jul 30, 2024
facchettos
reviewed
Jul 30, 2024
facchettos
reviewed
Jul 30, 2024
Comment on lines
+38
to
+41
| if len(watches) == 0 { | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
Its avoiding a goroutine creation so I guess the small check is worth it
FabianKramm
force-pushed
the
mappings-store
branch
from
fc137d5 to
d4a13e7
Compare
facchettos
approved these changes
Jul 30, 2024
FabianKramm
force-pushed
the
mappings-store
branch
9 times, most recently
from
7a3005b to
774dc77
Compare
FabianKramm
force-pushed
the
mappings-store
branch
from
774dc77 to
9bea0d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
Please provide a short message that should be published in the vcluster release notes
This PR adds a mapping store to vCluster that saves name and label mappings on the fly in a mapping store backend. This can be used to translate back resources including their metadata and simplifies importing as well as customising mappings.