feature: add controlPlane.distro.k8s.version chart value for CAPI #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
hidalgopl
force-pushed
the
add-chart-value-for-setting-k8s-version
branch
from
b51e00a to
e63b820
Compare
FabianKramm
reviewed
Aug 6, 2024
|
Besides the small comment above, LGTM! |
hidalgopl
force-pushed
the
add-chart-value-for-setting-k8s-version
branch
from
e63b820 to
b6b52f2
Compare
johannesfrey
reviewed
Aug 6, 2024
johannesfrey
reviewed
Aug 6, 2024
hidalgopl
force-pushed
the
add-chart-value-for-setting-k8s-version
branch
2 times, most recently
from
afdb933 to
7051fc2
Compare
johannesfrey
approved these changes
Aug 7, 2024
…mponents are in sync
hidalgopl
force-pushed
the
add-chart-value-for-setting-k8s-version
branch
from
7051fc2 to
819cf9a
Compare
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
FabianKramm
added a commit
that referenced
this pull request
Aug 7, 2024
[v0.20] Merge pull request #2031 from hidalgopl/add-chart-value-for-setting-k8s-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… intergration
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-2725
controlPlane.distro.k8s.versionis a shortcut to set image tags for.New behavior:
controlPlane.distro.k8s.versionwill override image tags only if they're not specified by user (so they're different than current default tag,v1.30.3. This only affectsk8sdistro.Please provide a short message that should be published in the vcluster release notes
Add
controlPlane.distro.k8s.versionto ease setting up the cluster control plane components version.What else do we need to know?
It's a bit unfortunate that I had to add the logic to the helm chart, but I don't see other way around it (open to suggestions!). Added a bunch of unit tests.