Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] now refuses to create multiple virtual clusters in same ns #2052

Merged
merged 2 commits into from
Aug 12, 2024
Merged

[enhancement] now refuses to create multiple virtual clusters in same ns #2052

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d13723
[enhancement] now refuses to create multiple virtual clusters in same ns
facchettos Aug 9, 2024
e4f114b
added command context
facchettos Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/cli/create_helm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,15 @@ func CreateHelm(ctx context.Context, options *CreateOptions, globalFlags *flags.
if err != nil {
return err
}
vclusters, err := find.ListVClusters(ctx, cmd.Context, "", cmd.Namespace, log)
if err != nil {
return err
}
for _, v := range vclusters {
if v.Namespace == cmd.Namespace && v.Name != vClusterName {
return fmt.Errorf("there is already a virtual cluster in namespace %s", cmd.Namespace)
}
}

err = cmd.prepare(ctx, vClusterName)
if err != nil {
Expand Down
Loading